Retry LB listener methods after timeout #8630
Conversation
ghost
added
size/XS
| @@ -493,6 +493,14 @@ func resourceAwsLbListenerCreate(d *schema.ResourceData, meta interface{}) error | |||
| return nil | |||
| }) | |||
|
|
|||
| if isResourceTimeoutError(err) { | |||
There was a problem hiding this comment.
When the error is a resource.TimeoutError and we hit this condition, its important that we reset the error object so the later error checking logic is not triggered. Otherwise as written this will work like the following:
resource.Retrysets top levelerrtoresource.TimeoutErrorisResourceTimeoutError(err)conditional runsCreateListeneragain (great!)- If
CreateListenerreturns an error, it returns the error - If
CreateListenerdoesn't return an error, theisResourceTimeoutError()conditional exits, but the below error check (if err != nil) will still have the originalresource.TimeoutErrorerror, so it will still return an error
The trick here is using a direct = assignment in Go instead of :=
This allows us to simplify this logic like the following:
// ... new logic here ...
if isResourceTimeoutError(err) {
_, err = elbconn.CreateListener(params)
}
// ... existing error handling below here ...
if err != nil {
return fmt.Errorf("Error creating LB Listener: %s", err)
}
// ... existing happy path ...You'll now get the outcome you're expecting both ways when resource.Retry has a timeout error:
resource.Retrysets top levelerrtoresource.TimeoutErrorisResourceTimeoutError(err)conditional runsCreateListeneragain (great!)- If
CreateListenerreturns an error, it resets the top level error object and the below error check (if err != nil) will return that error - If
CreateListenerdoesn't return an error, the top level error object is reset toniland the below error check (if err != nil) will not trigger so the resource will continue on its merry way on the happy path
Hope this helps!
|
edit: Whoops I thought the original issue reference was the tech debt issue (#7873), but it might be good to reference that one as well. 😅 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Community Note
Fixes #8025
Release note for CHANGELOG:
Output from acceptance testing: